-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embedded private method interfaces in metric API #3916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
=======================================
- Coverage 81.7% 81.7% -0.1%
=======================================
Files 171 171
Lines 12951 12951
=======================================
- Hits 10590 10586 -4
- Misses 2138 2142 +4
Partials 223 223
|
pellared
reviewed
Mar 28, 2023
Co-authored-by: Robert Pająk <[email protected]>
pellared
approved these changes
Mar 29, 2023
pellared
approved these changes
Mar 29, 2023
MadVikingGod
approved these changes
Mar 29, 2023
Aneurysm9
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3865
This adds an
embedded
sub-package tootel/metric
. It contains interfaces fromotel/metric
but only with a single unexported method. These interfaces are embedded in all their corresponding interfaces inotel/metric
. This means that from the SDK developers perspective they need to ...embedded
interface if they want their SDK to have a compile time error if an interface fromotel/metric
has a method added to it.otel/metric
interfaces if they want to have runtime panicsHaving the embedded interfaces in their own package removes the distraction for instrumentation authors who have no need to interact with the types in
embedded
.