-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Refactor view implementation #3397
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have NewView take filter and apply masks to construct a view directly, instead of taking variable number of matching functions.
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Oct 25, 2022
4 tasks
MrAlias
changed the title
[WIP] Refactor view implementation
[Proposal] Refactor view implementation
Oct 26, 2022
MrAlias
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
and removed
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Oct 26, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
=======================================
+ Coverage 77.8% 78.0% +0.2%
=======================================
Files 164 165 +1
Lines 11497 11603 +106
=======================================
+ Hits 8945 9055 +110
+ Misses 2349 2346 -3
+ Partials 203 202 -1
|
MrAlias
force-pushed
the
view-deprecate
branch
from
October 26, 2022 21:10
09e111f
to
45b1008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3399