-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate views with MeterProvider instead of Reader #3387
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
=======================================
- Coverage 77.9% 77.9% -0.1%
=======================================
Files 164 164
Lines 11361 11366 +5
=======================================
- Hits 8861 8859 -2
- Misses 2301 2307 +6
- Partials 199 200 +1
|
fb892b0
to
dee651b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it was last discussed, we took a views-per-reader approach specifically to support the use case: High-frequency export of a subset of metrics, and a low-frequency export of a full set. E.g. every 10 seconds get status + response counts, and for every minute get the histogram of response times + everything else.
It doesn't look like we can support this use case with this approach.
That being said, we are the only project that does this.
I think this is the key. If the OTel community decides to add support for this in the future we can definitely add it back. 👍 |
Resolve #3241
Resolve #3210
Resolve #3085
Follow the v1.14.0 version of the metric SDK specification and register views with a
MeterProvider
instead of with aReader
.This change naturally includes a resolution to #3085 as there is no longer a need to map readers to views.