Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go.opentelemetry.io/proto to v0.15.0 #2748

Merged
merged 7 commits into from
Mar 30, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 28, 2022

Fix #2747

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #2748 (05ee0b6) into main (bbcdc75) will increase coverage by 0.0%.
The diff coverage is 63.1%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2748   +/-   ##
=====================================
  Coverage   76.7%   76.8%           
=====================================
  Files        181     181           
  Lines      12175   12174    -1     
=====================================
+ Hits        9347    9350    +3     
+ Misses      2603    2599    -4     
  Partials     225     225           
Impacted Files Coverage Δ
...lp/otlpmetric/internal/otlpmetrictest/collector.go 0.0% <0.0%> (ø)
...otlp/otlptrace/internal/otlptracetest/collector.go 0.0% <0.0%> (ø)
.../otlp/otlptrace/internal/otlptracetest/otlptest.go 0.0% <0.0%> (ø)
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.5% <92.8%> (ø)
...otlp/otlpmetric/internal/metrictransform/metric.go 78.1% <100.0%> (+<0.1%) ⬆️
...lptrace/internal/tracetransform/instrumentation.go 100.0% <100.0%> (ø)
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+0.9%) ⬆️

@MrAlias MrAlias force-pushed the upgrade-proto-v0.15.0 branch from aeee5b7 to 05ee0b6 Compare March 29, 2022 17:01
@MrAlias MrAlias marked this pull request as ready for review March 29, 2022 17:04
@MrAlias MrAlias added this to the Release v1.7.0 milestone Mar 30, 2022
@MrAlias MrAlias merged commit 6287236 into open-telemetry:main Mar 30, 2022
@MrAlias MrAlias deleted the upgrade-proto-v0.15.0 branch March 30, 2022 15:19
@bgranetzke
Copy link

@MrAlias I think this PR fixed a compile-time bug in metrics/0.23.0-current(0.28.0)
https://github.com/open-telemetry/opentelemetry-go/pull/2748/files#diff-c1ccbe4e557a5f58361fbcc64ecbd6c1efeb90b5a10659113ffe25cc0cd9d81bR428

Do we need to also bump up the metrics* tags for this release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go.opentelemetry.io/proto to v0.15.0
4 participants