-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Logging for sdk/trace #2500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to OTLP exporters having MarshalLog methods 🚀
To help people see how this change would affect things you can run the NamedTracer example and see the output:
I would also like to add the formating of these logs in entirely controlled by the logger, so if we were to use for example a json logger we would have a different output. |
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
=======================================
- Coverage 76.3% 76.0% -0.4%
=======================================
Files 174 174
Lines 12027 12084 +57
=======================================
+ Hits 9182 9188 +6
- Misses 2600 2653 +53
+ Partials 245 243 -2
|
This addresses the lack of configuration visibility of our sdk.
Closes #2499
This does not address all exporters, just stdout. Aditional exporters can be addressed after we establish a working pattern.