Add Float64CounterObserver and Float64UpDownCounterObserver Tests #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichsueh3
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2487 +/- ##
=======================================
- Coverage 76.3% 76.3% -0.1%
=======================================
Files 174 174
Lines 12027 12027
=======================================
- Hits 9184 9182 -2
- Misses 2598 2600 +2
Partials 245 245
|
Aneurysm9
approved these changes
Dec 28, 2021
XSAM
approved these changes
Dec 29, 2021
MrAlias
approved these changes
Jan 3, 2022
dashpole
approved these changes
Jan 4, 2022
|
Please rebase so this can be merged. |
…into add_prometheus_tests
…pentelemetry-go into add_prometheus_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2466 and adds tests for the
Float64CounterObserverandFloat64UpDownCounterObserverinstruments, meaning all six instrument kinds will be tested.