Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Aggregator interface to aggregator package #2444

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

bogdandrutu
Copy link
Member

Updates #2273

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu
Copy link
Member Author

@MrAlias I think it is ok to skip changelog for this since it is not released and is part of the same entry I added in the initial PR.

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #2444 (a10775f) into main (4702f6f) will increase coverage by 0.0%.
The diff coverage is 91.3%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2444   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        173     173           
  Lines      12010   12010           
=====================================
+ Hits        9167    9174    +7     
+ Misses      2598    2593    -5     
+ Partials     245     243    -2     
Impacted Files Coverage Δ
sdk/metric/processor/basic/basic.go 96.9% <ø> (ø)
sdk/metric/aggregator/aggregatortest/test.go 81.0% <60.0%> (ø)
sdk/metric/aggregator/aggregator.go 100.0% <100.0%> (ø)
sdk/metric/aggregator/histogram/histogram.go 97.4% <100.0%> (ø)
sdk/metric/aggregator/lastvalue/lastvalue.go 87.7% <100.0%> (ø)
sdk/metric/aggregator/sum/sum.go 89.6% <100.0%> (ø)
sdk/metric/export/metric.go 100.0% <100.0%> (ø)
sdk/metric/processor/processortest/test.go 84.1% <100.0%> (ø)
sdk/metric/sdk.go 81.5% <100.0%> (+1.4%) ⬆️
sdk/metric/selector/simple/simple.go 100.0% <100.0%> (ø)
... and 2 more

@bogdandrutu bogdandrutu added the area:metrics Part of OpenTelemetry Metrics label Dec 14, 2021
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 14, 2021
@MrAlias MrAlias merged commit 4654d78 into open-telemetry:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants