move global trace provider api to global package.#240
Merged
rghetia merged 3 commits intoopen-telemetry:masterfrom Oct 25, 2019
Merged
move global trace provider api to global package.#240rghetia merged 3 commits intoopen-telemetry:masterfrom
rghetia merged 3 commits intoopen-telemetry:masterfrom
Conversation
rghetia
requested review from
bogdandrutu,
jmacd,
pjanotti,
sjkaris and
tedsuo
as code owners
cbandy
reviewed
Oct 25, 2019
|
|
||
| // GlobalProvider returns trace provider registered with global registry. | ||
| // If no trace provider is registered then an instance of NoopTraceProvider is returned. | ||
| // TraceProvider returns registered global trace provider. |
Contributor
There was a problem hiding this comment.
Suggested change
| // TraceProvider returns registered global trace provider. | |
| // TraceProvider returns the registered global trace provider. |
or
Suggested change
| // TraceProvider returns registered global trace provider. | |
| // TraceProvider returns the configured global trace provider. |
| // SetGlobalProvider sets the provider as a global trace provider. | ||
| func SetGlobalProvider(m Provider) { | ||
| globalP.Store(globalProvider{p: m}) | ||
| // SetTraceProvider configures the provider as a global trace provider. |
Contributor
There was a problem hiding this comment.
Suggested change
| // SetTraceProvider configures the provider as a global trace provider. | |
| // SetTraceProvider registers p as the global trace provider. |
or
Suggested change
| // SetTraceProvider configures the provider as a global trace provider. | |
| // SetTraceProvider configures p to be the global trace provider. |
Contributor
|
There is a static function in I think this should be eliminated. There should be no uses of a global from within the |
Contributor
Author
It was eliminated in #227 |
jmacd
approved these changes
Oct 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially addresses #216