-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sdk/export/metric module, embed into the sdk/metric #2382
Conversation
dcdd834
to
c91e34f
Compare
Codecov Report
@@ Coverage Diff @@
## main #2382 +/- ##
=======================================
+ Coverage 76.0% 76.3% +0.3%
=======================================
Files 173 173
Lines 12010 12010
=======================================
+ Hits 9132 9170 +38
+ Misses 2633 2595 -38
Partials 245 245
|
0ed195c
to
ae92308
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please deprecate the old package instead of removing so users know what to use instead. We can remove in the following release to the release that includes this deprecation.
See #2273. |
2d4598b
to
9b2404b
Compare
@bogdandrutu all the dependent PRs have merged. Are you able to update this PR to deprecate the package? |
07e40b0
to
7fec1ff
Compare
@MrAlias deprecation is done. |
7fec1ff
to
faf0e47
Compare
faf0e47
to
3f91b9e
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
3f91b9e
to
03f3482
Compare
Updates #2273.
Signed-off-by: Bogdan Drutu [email protected]