Add semconv/v1.5.0 package#2322
Merged
Aneurysm9 merged 3 commits intoopen-telemetry:mainfrom Oct 25, 2021
Merged
Conversation
Generated from a modified version of the v1.5.0 release of the specification using a modified version of the semconvgen tools. The specification contained capitalized IDs that caused errors from the semconvgen tool. These errors were manually resolved and the rest of the Go formatting tools were used to provide consistent code. Important to note, the Go semconvgen tooling includes new name capitalization rules for ReplicaSet, StatefulSet, and DaemonSet that mean code names are not backwards compatible. This is included in the changelog to help users perform the upgrade.
MrAlias
requested review from
Aneurysm9,
MadVikingGod,
XSAM,
dashpole,
evantorrie,
jmacd,
paivagustavo and
pellared
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
+ Coverage 73.3% 73.6% +0.3%
=======================================
Files 174 175 +1
Lines 12245 12409 +164
=======================================
+ Hits 8976 9137 +161
- Misses 3035 3039 +4
+ Partials 234 233 -1
|
Member
|
I assume this is done according to these instructions: https://github.com/open-telemetry/opentelemetry-go/blob/main/RELEASING.md#semantic-convention-generation Do you also plan to repeat this for specs 1.6.1 and 1.7.0? |
tigrannajaryan
approved these changes
Oct 21, 2021
Member
Nevermind, I see the PRs. |
pellared
approved these changes
Oct 21, 2021
Aneurysm9
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from a modified version of the v1.5.0 release of the specification using a modified version of the semconvgen tools. The specification contained capitalized IDs that caused errors from the semconvgen tool. These errors were manually resolved and the rest of the Go formatting tools were used to provide consistent code. The changes were then double checked by looking at a diff in the specification and in the generated code between the v1.4.0 and v1.5.0 tags. All the changes made were valid.
Important to note, the Go semconvgen tooling includes new name capitalization rules for ReplicaSet, StatefulSet, and DaemonSet that mean code names are not backwards compatible. This is included in the changelog to help users perform the upgrade.