Fix flaky test TestSimpleSpanProcessorShutdownHonorsContextCancel#2290
Merged
MrAlias merged 9 commits intoopen-telemetry:mainfrom Oct 19, 2021
Merged
Fix flaky test TestSimpleSpanProcessorShutdownHonorsContextCancel#2290MrAlias merged 9 commits intoopen-telemetry:mainfrom
MrAlias merged 9 commits intoopen-telemetry:mainfrom
Conversation
MrAlias
requested review from
Aneurysm9,
MadVikingGod,
XSAM,
dashpole,
evantorrie,
jmacd,
paivagustavo and
pellared
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2290 +/- ##
=====================================
Coverage 72.6% 72.6%
=====================================
Files 172 172
Lines 11898 11911 +13
=====================================
+ Hits 8643 8658 +15
+ Misses 3021 3020 -1
+ Partials 234 233 -1
|
pellared
reviewed
Oct 15, 2021
pellared
reviewed
Oct 15, 2021
pellared
previously approved these changes
Oct 15, 2021
XSAM
previously approved these changes
Oct 16, 2021
pellared
reviewed
Oct 16, 2021
pellared
dismissed
their stale review
I am not convinced that it is a bug. I prefer others to judge
pellared
reviewed
Oct 18, 2021
pellared
reviewed
Oct 18, 2021
MrAlias
dismissed
XSAM’s stale review
Please take another look. The strategy has changed enough to need a new review.
XSAM
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2289