Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ExportKind to Temporality #2272

Closed

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Oct 1, 2021

The name ExportKind predates the use of Temporality in OTel. Fix the usages here.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #2272 (b406a64) into main (66fccc0) will not change coverage.
The diff coverage is 88.4%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2272   +/-   ##
=====================================
  Coverage   72.5%   72.5%           
=====================================
  Files        168     168           
  Lines      11874   11874           
=====================================
  Hits        8611    8611           
  Misses      3029    3029           
  Partials     234     234           
Impacted Files Coverage Δ
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <0.0%> (ø)
sdk/export/metric/temporality_string.go 0.0% <0.0%> (ø)
sdk/metric/controller/controllertest/test.go 100.0% <ø> (ø)
sdk/metric/processor/processortest/test.go 85.5% <85.7%> (ø)
bridge/opencensus/exporter.go 100.0% <100.0%> (ø)
exporters/otlp/otlpmetric/exporter.go 60.6% <100.0%> (ø)
...otlp/otlpmetric/internal/metrictransform/metric.go 79.0% <100.0%> (ø)
exporters/otlp/otlpmetric/options.go 100.0% <100.0%> (ø)
exporters/prometheus/prometheus.go 65.2% <100.0%> (ø)
exporters/stdout/stdoutmetric/metric.go 76.2% <100.0%> (ø)
... and 2 more

@jmacd
Copy link
Contributor Author

jmacd commented Oct 1, 2021

I realized two things:
(1) we've discussed this in the past and as a group we try to spell out "AggregationTemporality".
(2) this goes better as a type named aggregation.Temporality

@jmacd jmacd closed this Oct 1, 2021
@jmacd jmacd deleted the jmacd/exportkind_temporality branch October 1, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants