chore: adds vanity import check.#2255
Merged
Aneurysm9 merged 12 commits intoopen-telemetry:mainfrom Sep 28, 2021
Merged
Conversation
5444762 to
42c8f06
Compare
Member
MrAlias
reviewed
Sep 27, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Contributor
Author
|
@pellared that was actually an idea but first I wanted to see this in action here. |
Contributor
Author
|
This is failing now on purpose. I wanted it to fail to test the setup. |
Contributor
Author
|
Do we need to update changelog? |
Aneurysm9
approved these changes
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #2255 +/- ##
=====================================
Coverage 72.4% 72.5%
=====================================
Files 168 168
Lines 11872 11872
=====================================
+ Hits 8606 8609 +3
+ Misses 3031 3029 -2
+ Partials 235 234 -1
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds check on CI to verify vanity imports are rightfully added.