Skip to content

chore(exporter/zipkin): improves logging on invalid collector. #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aneurysm9 merged 3 commits into from
Aug 30, 2021
Merged

chore(exporter/zipkin): improves logging on invalid collector. #2191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95ba8a2
chore(exporter/zipkin): improves logging on invalid collector.
jcchavezs Aug 18, 2021
2e49694
tests: fixes tests.
jcchavezs Aug 19, 2021
5ec479c
Merge branch 'main' into patch-1
Aneurysm9 Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exporters/zipkin/zipkin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ func New(collectorURL string, opts ...Option) (*Exporter, error) {
}
u, err := url.Parse(collectorURL)
if err != nil {
return nil, fmt.Errorf("invalid collector URL: %v", err)
return nil, fmt.Errorf("invalid collector URL %q: %v", collectorURL, err)
}
if u.Scheme == "" || u.Host == "" {
return nil, errors.New("invalid collector URL")
return nil, fmt.Errorf("invalid collector URL %q: no scheme or host", collectorURL)
}

cfg := config{}
Expand Down
2 changes: 1 addition & 1 deletion exporters/zipkin/zipkin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestNewRawExporterShouldFailInvalidCollectorURL(t *testing.T) {
)

assert.Error(t, err)
assert.EqualError(t, err, "invalid collector URL")
assert.EqualError(t, err, "invalid collector URL \"localhost\": no scheme or host")
assert.Nil(t, exp)
}

Expand Down