Skip to content

Clarify the attribute package documentation and order/grouping#2168

Merged
MrAlias merged 7 commits intoopen-telemetry:mainfrom
MrAlias:attr-key-doc
Aug 11, 2021
Merged

Clarify the attribute package documentation and order/grouping#2168
MrAlias merged 7 commits intoopen-telemetry:mainfrom
MrAlias:attr-key-doc

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Aug 6, 2021

Remove the outdated package name from the documentation that recommends using the convenience functions. Move the Int method closer to the Int64 method.

Part of #2162

@MrAlias MrAlias added documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 6, 2021
@MrAlias MrAlias changed the title Clarify the attribute package Key method documentation and order/grouping Clarify the attribute package documentation and order/grouping Aug 6, 2021
@MrAlias MrAlias marked this pull request as draft August 6, 2021 17:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2021

Codecov Report

Merging #2168 (e91e754) into main (5d25c4d) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2168   +/-   ##
=====================================
  Coverage   72.3%   72.3%           
=====================================
  Files        176     176           
  Lines      12093   12093           
=====================================
  Hits        8755    8755           
  Misses      3100    3100           
  Partials     238     238           
Impacted Files Coverage Δ
attribute/key.go 100.0% <100.0%> (ø)
attribute/kv.go 90.0% <100.0%> (ø)
attribute/value.go 93.1% <100.0%> (ø)

@MrAlias MrAlias marked this pull request as ready for review August 6, 2021 17:50
Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nit comments

Comment thread attribute/key.go Outdated
Comment thread attribute/key.go Outdated
Comment thread attribute/kv.go Outdated
Comment thread attribute/key.go Outdated
Comment thread attribute/key.go Outdated
Comment thread attribute/key.go Outdated
Comment thread attribute/key.go Outdated
Comment thread attribute/key.go Outdated
@MrAlias MrAlias merged commit a882ee3 into open-telemetry:main Aug 11, 2021
@MrAlias MrAlias deleted the attr-key-doc branch August 11, 2021 17:08
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants