Skip to content

Move OpenCensus bridge integration tests to their own module#2165

Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom
MrAlias:oc-integration-test-pkg
Aug 9, 2021
Merged

Move OpenCensus bridge integration tests to their own module#2165
MrAlias merged 3 commits intoopen-telemetry:mainfrom
MrAlias:oc-integration-test-pkg

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Aug 6, 2021

Part of #2144 and #2121

Use the default SDK to test the OpenCensus bridge. In order to not add the SDK as a dependency to the bridge module and require users to depend on it if they use the bridge these tests are moved to a new dedicated test module.

This removes the use of the oteltest package in favor of the sdk/trace/tracetest package.

Use the default SDK to test the OpenCensus bridge. In order to not add
the SDK as a dependency to the bridge module and require users to depend
on it if they use the bridge these tests are moved to a new dedicated
test module.
@MrAlias MrAlias added pkg:bridges Related to a bridge package Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 6, 2021
@MrAlias MrAlias mentioned this pull request Aug 6, 2021
5 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2021

Codecov Report

Merging #2165 (feb1f40) into main (89a9489) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2165     +/-   ##
=======================================
- Coverage   72.4%   72.4%   -0.1%     
=======================================
  Files        176     176             
  Lines      12091   12091             
=======================================
- Hits        8759    8755      -4     
- Misses      3094    3098      +4     
  Partials     238     238             
Impacted Files Coverage Δ
bridge/opencensus/bridge.go 0.0% <0.0%> (-100.0%) ⬇️
bridge/opencensus/utils/utils.go 0.0% <0.0%> (-50.0%) ⬇️

@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented Aug 6, 2021

The code coverage is offset in #2164

@MrAlias MrAlias merged commit b1d1d52 into open-telemetry:main Aug 9, 2021
@MrAlias MrAlias deleted the oc-integration-test-pkg branch August 9, 2021 16:24
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:bridges Related to a bridge package Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants