Move OpenCensus bridge integration tests to their own module#2165
Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom Aug 9, 2021
Merged
Move OpenCensus bridge integration tests to their own module#2165MrAlias merged 3 commits intoopen-telemetry:mainfrom
MrAlias merged 3 commits intoopen-telemetry:mainfrom
Conversation
Use the default SDK to test the OpenCensus bridge. In order to not add the SDK as a dependency to the bridge module and require users to depend on it if they use the bridge these tests are moved to a new dedicated test module.
Codecov Report
@@ Coverage Diff @@
## main #2165 +/- ##
=======================================
- Coverage 72.4% 72.4% -0.1%
=======================================
Files 176 176
Lines 12091 12091
=======================================
- Hits 8759 8755 -4
- Misses 3094 3098 +4
Partials 238 238
|
Contributor
Author
|
The code coverage is offset in #2164 |
jmacd
approved these changes
Aug 6, 2021
dashpole
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2144 and #2121
Use the default SDK to test the OpenCensus bridge. In order to not add the SDK as a dependency to the bridge module and require users to depend on it if they use the bridge these tests are moved to a new dedicated test module.
This removes the use of the
oteltestpackage in favor of thesdk/trace/tracetestpackage.