Deprecate oteltest.Harness for removal#2123
Merged
Aneurysm9 merged 6 commits intoopen-telemetry:mainfrom Jul 26, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2123 +/- ##
=======================================
- Coverage 73.6% 71.5% -2.1%
=======================================
Files 168 169 +1
Lines 8234 8235 +1
=======================================
- Hits 6062 5893 -169
- Misses 1933 2102 +169
- Partials 239 240 +1
|
Aneurysm9
approved these changes
Jul 22, 2021
bogdandrutu
reviewed
Jul 22, 2021
pellared
approved these changes
Jul 26, 2021
85b2b59 to
89dd8ef
Compare
remove `oteltest` import.
89dd8ef to
4007fe6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This harness is intended to validate the specified functionality of an SDK. It only partially does this as it has not been maintained as the specification evolved. Having a stale testing structure is acceptable in helping this project prevent regressions until we have time to update or replace it, but exporting this for users to rely on is not okay.
This deprecates the harness with the intent to remove it in the next release as it looks like this is the only published project, outside of copies, that uses it. To achieve the prevention of regressions mentioned above, this makes an internal copy of the harness that is expected to last when the original is removed.
Part of #2121