Skip to content

API: create new linked span from current context#2115

Merged
MrAlias merged 7 commits intoopen-telemetry:mainfrom
bhautikpip:add_link_from_context_api
Jul 22, 2021
Merged

API: create new linked span from current context#2115
MrAlias merged 7 commits intoopen-telemetry:mainfrom
bhautikpip:add_link_from_context_api

Conversation

@bhautikpip
Copy link
Copy Markdown
Contributor

@bhautikpip bhautikpip commented Jul 21, 2021

Added API LinkFromContext to return Link which encapsulates SpanContext from provided context and also encapsulates attributes

Resolve #2068
Resolve #2067

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2021

Codecov Report

Merging #2115 (e78a735) into main (db81d4a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2115   +/-   ##
=====================================
  Coverage   72.9%   72.9%           
=====================================
  Files        167     167           
  Lines       8237    8240    +3     
=====================================
+ Hits        6009    6014    +5     
+ Misses      1994    1992    -2     
  Partials     234     234           
Impacted Files Coverage Δ
trace/trace.go 98.3% <100.0%> (+<0.1%) ⬆️
exporters/jaeger/jaeger.go 94.2% <0.0%> (+1.1%) ⬆️

Comment thread trace/trace.go Outdated
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Jul 22, 2021

Looks like this needs a changelog entry before we can merge it.

@bhautikpip
Copy link
Copy Markdown
Contributor Author

Thanks @MrAlias I will update the CHANGELOG.

@MrAlias MrAlias merged commit abe2243 into open-telemetry:main Jul 22, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a new linked Span from the current Context Adding Link from an existing context is too verbose, some helper would be appreciated.

5 participants