Skip to content

Update internal/global/trace testing#2111

Merged
MrAlias merged 5 commits intoopen-telemetry:mainfrom
MrAlias:gtrace-test-deps
Jul 22, 2021
Merged

Update internal/global/trace testing#2111
MrAlias merged 5 commits intoopen-telemetry:mainfrom
MrAlias:gtrace-test-deps

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jul 21, 2021

Use existing testing types instead of the oteltest package.

Part of #2077

Use existing testing types instead of the oteltest package.
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 21, 2021

Codecov Report

Merging #2111 (14b6fc7) into main (7f10ef7) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2111     +/-   ##
=======================================
- Coverage   73.1%   72.9%   -0.2%     
=======================================
  Files        167     167             
  Lines       8237    8237             
=======================================
- Hits        6027    6011     -16     
- Misses      1977    1992     +15     
- Partials     233     234      +1     
Impacted Files Coverage Δ
oteltest/config.go 72.9% <0.0%> (-21.7%) ⬇️
trace/config.go 61.2% <0.0%> (-14.3%) ⬇️
oteltest/span.go 97.1% <0.0%> (-2.9%) ⬇️
trace/noop.go 56.2% <0.0%> (+6.2%) ⬆️

Comment thread internal/global/trace_test.go
@MrAlias MrAlias merged commit db81d4a into open-telemetry:main Jul 22, 2021
@MrAlias MrAlias deleted the gtrace-test-deps branch July 22, 2021 16:12
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants