Skip to content

Unify OTLP exporter retry logic#2095

Merged
MrAlias merged 19 commits intoopen-telemetry:mainfrom
MrAlias:otlp-retry-conf
Jul 22, 2021
Merged

Unify OTLP exporter retry logic#2095
MrAlias merged 19 commits intoopen-telemetry:mainfrom
MrAlias:otlp-retry-conf

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jul 16, 2021

Update the otlptracehttp and otlptracegrpc to use the same retry logic and configuration.

Resolve #2024

@MrAlias MrAlias added the pkg:exporter:otlp Related to the OTLP exporter package label Jul 16, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2021

Codecov Report

Merging #2095 (a249181) into main (abe2243) will increase coverage by 0.5%.
The diff coverage is 85.8%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2095     +/-   ##
=======================================
+ Coverage   72.9%   73.5%   +0.5%     
=======================================
  Files        167     168      +1     
  Lines       8240    8233      -7     
=======================================
+ Hits        6014    6058     +44     
+ Misses      1992    1935     -57     
- Partials     234     240      +6     
Impacted Files Coverage Δ
...ters/otlp/otlptrace/internal/otlpconfig/options.go 72.5% <50.0%> (+6.4%) ⬆️
exporters/otlp/otlptrace/otlptracehttp/client.go 84.0% <78.0%> (-9.3%) ⬇️
...s/otlp/otlptrace/internal/connection/connection.go 13.7% <90.9%> (+11.3%) ⬆️
exporters/otlp/otlptrace/internal/retry/retry.go 100.0% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracegrpc/options.go 79.1% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/options.go 100.0% <100.0%> (ø)

Copy link
Copy Markdown
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias marked this pull request as ready for review July 19, 2021 18:09
@MrAlias MrAlias merged commit cb607b0 into open-telemetry:main Jul 22, 2021
@MrAlias MrAlias deleted the otlp-retry-conf branch July 22, 2021 22:07
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:exporter:otlp Related to the OTLP exporter package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify OTLP HTTP and gRPC retry settings

4 participants