export ToZipkinSpanModels for use outside this library#2027
Merged
Aneurysm9 merged 3 commits intoopen-telemetry:mainfrom Jun 23, 2021
Merged
export ToZipkinSpanModels for use outside this library#2027Aneurysm9 merged 3 commits intoopen-telemetry:mainfrom
Aneurysm9 merged 3 commits intoopen-telemetry:mainfrom
Conversation
coryb
requested review from
Aneurysm9,
MadVikingGod,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
paivagustavo
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #2027 +/- ##
=====================================
Coverage 72.7% 72.7%
=====================================
Files 164 164
Lines 8079 8079
=====================================
+ Hits 5876 5880 +4
+ Misses 1974 1972 -2
+ Partials 229 227 -2
|
Aneurysm9
approved these changes
Jun 22, 2021
Aneurysm9
added
the
blocked:CLA
MrAlias
reviewed
Jun 22, 2021
coryb
force-pushed
the
export-toZipkinSpanModels
branch
from
aa06b68 to
a2f0d2b
Compare
MrAlias
removed
the
blocked:CLA
MrAlias
reviewed
Jun 22, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Jun 22, 2021
Aneurysm9
approved these changes
Jun 23, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently started using OpenTelemetry and need to publish to an internal Zipkin compatible service without using the normal http service. There is a lot of useful code in this package for converting the spans I am hoping to be able to reuse this library rather than copy/paste it into my project.
Thanks for your consideration!