-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release 1.0.0-RC1 #2013
Merged
Aneurysm9
merged 11 commits into
open-telemetry:main
from
Aneurysm9:pre_release_1.0.0-RC1
Jun 18, 2021
Merged
Pre-release 1.0.0-RC1 #2013
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7646e8e
Add versions.yaml to specify module version sets
Aneurysm9 bc053b4
Prepare for releasing v1.0.0-RC1
Aneurysm9 54c28f5
Update experimental-metrics and bridge module sets to v0.21.0
Aneurysm9 faaf0a8
Prepare for releasing v0.21.0
Aneurysm9 3462b4d
Prepare for releasing v0.21.0
Aneurysm9 ac74b80
Fixup go.mod version references
Aneurysm9 7e1465e
Update version.go
Aneurysm9 b28d0de
Update CHANGELOG
Aneurysm9 4e492d3
Update godoc references to "pre-GA phase" for RC1 packages
Aneurysm9 ca3bf47
Update website_docs for 1.0.0-RC1
Aneurysm9 728cb35
Merge branch 'main' into pre_release_1.0.0-RC1
Aneurysm9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about changing the tag name to
v1.0.0-rc.1
This is the convention that SemVer uses itself.
Example: https://semver.org/spec/v2.0.0-rc.1.html
Or at least
v1.0.0-rc1
- I have never seen the capitalsRC
in tags before 😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed in the SIG meeting and it is valid semver accepted by the Go module tooling. There's not a strong reason to change it. Plus, RC is an initialism and Go conventions dictate it be in all caps :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK😉
I also saw such patterns under: https://blog.golang.org/publishing-go-modules
And https://golang.org/ref/mod also has lowercase.
But it is not anything critical. Just a matter of taste 😄