Skip to content

Use mock server as jaeger agent listener #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrAlias merged 3 commits into from
Jun 8, 2021
+21 −3
Merged

Use mock server as jaeger agent listener #1930

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
deeb365
Use mock server as jaeger agent listener.
tianyaqu May 18, 2021
2ea6a63
Merge branch 'main' into use-mock-server-as-jaeger-agent
Aneurysm9 May 27, 2021
02bf7ac
Merge branch 'main' into use-mock-server-as-jaeger-agent
MrAlias Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions exporters/trace/jaeger/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,18 @@ func (eh errorHandler) Handle(err error) { assert.NoError(eh.t, err) }
func TestJaegerAgentUDPLimitBatching(t *testing.T) {
otel.SetErrorHandler(errorHandler{t})

mockServer, err := newUDPListener()
require.NoError(t, err)
defer mockServer.Close()
host, port, err := net.SplitHostPort(mockServer.LocalAddr().String())
assert.NoError(t, err)

// 1500 spans, size 79559, does not fit within one UDP packet with the default size of 65000.
n := 1500
s := make(tracetest.SpanStubs, n).Snapshots()

exp, err := NewRawExporter(
WithAgentEndpoint(WithAgentHost("localhost"), WithAgentPort("6831")),
WithAgentEndpoint(WithAgentHost(host), WithAgentPort(port)),
)
require.NoError(t, err)

Expand All @@ -135,14 +141,20 @@ func generateALargeSpan() tracetest.SpanStub {
func TestSpanExceedsMaxPacketLimit(t *testing.T) {
otel.SetErrorHandler(errorHandler{t})

mockServer, err := newUDPListener()
require.NoError(t, err)
defer mockServer.Close()
host, port, err := net.SplitHostPort(mockServer.LocalAddr().String())
assert.NoError(t, err)

// 106 is the serialized size of a span with default values.
maxSize := 106

largeSpans := tracetest.SpanStubs{generateALargeSpan(), {}}.Snapshots()
normalSpans := tracetest.SpanStubs{{}, {}}.Snapshots()

exp, err := NewRawExporter(
WithAgentEndpoint(WithAgentHost("localhost"), WithAgentPort("6831"), WithMaxPacketSize(maxSize+1)),
WithAgentEndpoint(WithAgentHost(host), WithAgentPort(port), WithMaxPacketSize(maxSize+1)),
)
require.NoError(t, err)

Expand All @@ -155,12 +167,18 @@ func TestSpanExceedsMaxPacketLimit(t *testing.T) {
func TestEmitBatchWithMultipleErrors(t *testing.T) {
otel.SetErrorHandler(errorHandler{t})

mockServer, err := newUDPListener()
require.NoError(t, err)
defer mockServer.Close()
host, port, err := net.SplitHostPort(mockServer.LocalAddr().String())
assert.NoError(t, err)

span := generateALargeSpan()
largeSpans := tracetest.SpanStubs{span, span}.Snapshots()
// make max packet size smaller than span
maxSize := len(span.Name)
exp, err := NewRawExporter(
WithAgentEndpoint(WithAgentHost("localhost"), WithAgentPort("6831"), WithMaxPacketSize(maxSize)),
WithAgentEndpoint(WithAgentHost(host), WithAgentPort(port), WithMaxPacketSize(maxSize)),
)
require.NoError(t, err)

Expand Down