-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API configs. #1921
Update API configs. #1921
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
+ Coverage 79.5% 79.6% +0.1%
=======================================
Files 141 141
Lines 7464 7486 +22
=======================================
+ Hits 5941 5966 +25
+ Misses 1275 1271 -4
- Partials 248 249 +1
|
I'm not sure about the lint failure, they look unrelated to the changes introduced here. Other than the syntax error this all looks good! 😄 |
That is so strange. I got the error 123 once, but after re-running make I couldn't get it to reproduce. I also used the go test explorer extension, and all came back green. |
🤷 |
This change will update the configs in the base API,
go.opentelemetry.io/otel/trace
and go.opentelemetry.io/otel/metric`, to reflect our contributing documentation.Because these configs are consumed by the SDK, and any other alternative implementation, they can not be private. This also means that the members of these configs will need some accessor.
This will finish the last items of #1882, closes #536
In addition, this reorganizes spanOptions to prevent ignored options from being accepted in any steps. For example Span.End() no longer accepts attributes or links. Closes #1878