-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Convention generation tooling #1891
Conversation
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Just because I couldn't tell I created a gist of the differences between keys: https://gist.github.com/MadVikingGod/9d108870779419171e7edecafe86e323 This isn't a comment on if this is appropriate or not, just so others don't have to try and work this out. It looks like a few new Keys:
Major change of
And the removal of
|
Thanks for doing that analysis @MadVikingGod! I've added replacements to fix the There were some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice 👍 Added a just few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than finding the repo root magic, I think this is GTG.
var ( | ||
HTTPSchemeHTTP = HTTPSchemeKey.String("http") | ||
HTTPSchemeHTTPS = HTTPSchemeKey.String("https") | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just moved out of the other files? It doesn't seem like this was generated like the other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just moved out of the other files. It doesn't exist in the conventions and I'm not actually sure we should be introducing it, but it was used in some of the helpers here and I figured it was easier to move closer to its use and we can discuss whether to actually keep them separately if needed.
Signed-off-by: Anthony J Mirabella <[email protected]>
…s there Signed-off-by: Anthony J Mirabella <[email protected]>
…acements Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1891 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 139 139
Lines 7425 7425
=====================================
+ Hits 5892 5894 +2
+ Misses 1286 1285 -1
+ Partials 247 246 -1
|
This adds a tool to use the
otel/semconvgen
container image to generate resource and trace semantic conventions from the specification. It is not yet integrated with build processes and must be manually run, but it can produce constant and variable declarations with reasonable godoc.Fixes #1879.