Add schema URL support to Tracer #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aneurysm9 @MrAlias I am looking for your feedback to understand if this is the right direction. |
Codecov Report
@@ Coverage Diff @@
## main #1889 +/- ##
=====================================
Coverage 79.6% 79.7%
=====================================
Files 141 141
Lines 7486 7492 +6
=====================================
+ Hits 5964 5973 +9
+ Misses 1273 1271 -2
+ Partials 249 248 -1
|
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
25bd614 to
52c430c
Compare
Aneurysm9
reviewed
May 7, 2021
MrAlias
approved these changes
May 13, 2021
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
52c430c to
3555297
Compare
Closed
This adds support for schema URL to the Tracer according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) For the future: once the proto is updated we will need to populate the schema_url field in the messages.
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
3555297 to
faa7c69
Compare
tigrannajaryan
changed the title
tigrannajaryan
commented
May 27, 2021
| } | ||
|
|
||
| // InstrumentationVersion returns the version of the library providing instrumentation. | ||
| func (t *TracerConfig) InstrumentationVersion() string { | ||
| return t.instrumentationVersion | ||
| } | ||
|
|
||
| // SchemaURL returns the Schema URL of the telemetry emitted by the Tracer. | ||
| func (t *TracerConfig) SchemaURL() string { | ||
| return t.schemaURL |
There was a problem hiding this comment.
This is covered by TestSchemaURL, not sure why codecov says it is not.
tigrannajaryan
requested review from
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo and
XSAM
as code owners
|
@MrAlias @Aneurysm9 this is ready for review. |
Aneurysm9
approved these changes
May 27, 2021
Merged
tigrannajaryan
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Jul 21, 2021
The support was added in this PR open-telemetry/opentelemetry-go#1889
SergeyKanzhelev
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Jul 21, 2021
The support was added in this PR open-telemetry/opentelemetry-go#1889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for schema URL to the Tracer according to the specification:
open-telemetry/opentelemetry-specification#1666
(Link to replaced by the link to the spec after that PR is merged)
For the future: once the proto is updated we will need to populate the
schema_url field in the messages.