Make ExportSpans for Jaeger Exporter honor deadline#1773
Merged
MrAlias merged 11 commits intoopen-telemetry:mainfrom Apr 5, 2021
Merged
Make ExportSpans for Jaeger Exporter honor deadline#1773MrAlias merged 11 commits intoopen-telemetry:mainfrom
MrAlias merged 11 commits intoopen-telemetry:mainfrom
Conversation
humivo
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
paivagustavo
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1773 +/- ##
=======================================
- Coverage 78.7% 78.7% -0.1%
=======================================
Files 134 134
Lines 7136 7140 +4
=======================================
+ Hits 5618 5620 +2
- Misses 1272 1274 +2
Partials 246 246
|
This reverts commit 06e24cc.
paivagustavo
approved these changes
Apr 2, 2021
Aneurysm9
approved these changes
Apr 2, 2021
XSAM
approved these changes
Apr 5, 2021
MrAlias
requested changes
Apr 5, 2021
MrAlias
reviewed
Apr 5, 2021
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
Looks good other than we need to check the error string
MrAlias
approved these changes
Apr 5, 2021
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the ExportSpans method for Jaegar Exporter use AddWait instead of Add in order to honor the context deadline. Should resolve Issue #1730