Record links/events attribute drops independently#1771
Merged
MrAlias merged 7 commits intoopen-telemetry:mainfrom Apr 6, 2021
Merged
Record links/events attribute drops independently#1771MrAlias merged 7 commits intoopen-telemetry:mainfrom
MrAlias merged 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1771 +/- ##
=======================================
- Coverage 78.7% 78.7% -0.1%
=======================================
Files 134 134
Lines 7140 7144 +4
=======================================
Hits 5626 5626
- Misses 1270 1272 +2
- Partials 244 246 +2
|
Aneurysm9
approved these changes
Apr 1, 2021
paivagustavo
approved these changes
Apr 2, 2021
ad418b6 to
828c1db
Compare
XSAM
approved these changes
Apr 6, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
EventandLinkstruct types from thego.opentelemetry.io/otelpackage now include aDroppedAttributeCountfield to record the number of attributes that were not recorded due to configured limits being reached.Changed
DroppedAttributeCountfield of theSpanin thego.opentelemetry.io/otelpackage now only represents the number of attributes dropped for the span itself. It no longer is a conglomerate of itself, events, and link attributes that have been dropped.Resolves #1766