Update Jaeger environment variables#1752
Merged
MrAlias merged 15 commits intoopen-telemetry:mainfrom Apr 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1752 +/- ##
=======================================
- Coverage 78.7% 78.6% -0.2%
=======================================
Files 134 134
Lines 7180 7156 -24
=======================================
- Hits 5656 5628 -28
- Misses 1274 1278 +4
Partials 250 250
|
MrAlias
requested changes
Mar 31, 2021
MrAlias
requested changes
Apr 5, 2021
MrAlias
reviewed
Apr 5, 2021
added 2 commits
April 6, 2021 14:11
MrAlias
reviewed
Apr 6, 2021
Aneurysm9
approved these changes
Apr 8, 2021
Contributor
|
@s-nadendla this looks ready to merge, can you resolve the conflicts and merge the main branch in? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Jaeger environment variables to match Open Telemetry specification:
Removed
envServiceNameandenvTagssince the Jaeger exporter already gets attributes from a Resource that has its own system for determining environment values; overriding these values here is unnecessary. Removed this logic and the corresponding testsAddresses: #1639