Update SamplingParameters#1749
Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom Mar 30, 2021
Merged
Conversation
Remove HasRemoteParent fields from SamplingParameters. The HasRemoteParent field is a duplicate of the Remote field of the parent span context contained in the ParentContext. Change the `ParentContext` field from storing a `SpanContext` to a `context.Context` that holds the parent span. This is to conform with the OpenTelemetry specification and resolve open-telemetry#1727.
MrAlias
requested review from
Aneurysm9,
XSAM,
dashpole,
evantorrie,
jmacd and
paivagustavo
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1749 +/- ##
=======================================
- Coverage 78.0% 78.0% -0.1%
=======================================
Files 132 132
Lines 6944 6948 +4
=======================================
+ Hits 5420 5422 +2
- Misses 1274 1276 +2
Partials 250 250
|
paivagustavo
approved these changes
Mar 29, 2021
Aneurysm9
approved these changes
Mar 30, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove HasRemoteParent fields from SamplingParameters. The HasRemoteParent field is a duplicate of the Remote field of the parent span context contained in the ParentContext.
Change the
ParentContextfield from storing aSpanContextto acontext.Contextthat holds the parent span. This is to conform with the OpenTelemetry specification.Resolves #1727