improve OTLP/gRPC connection errors#1737
Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom Mar 31, 2021
paivagustavo:improve_otlpgrpc_connection_error
Merged
improve OTLP/gRPC connection errors#1737MrAlias merged 3 commits intoopen-telemetry:mainfrom paivagustavo:improve_otlpgrpc_connection_error
MrAlias merged 3 commits intoopen-telemetry:mainfrom
paivagustavo:improve_otlpgrpc_connection_error
Conversation
paivagustavo
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1737 +/- ##
=====================================
Coverage 78.1% 78.2%
=====================================
Files 132 132
Lines 6948 6948
=====================================
+ Hits 5430 5434 +4
+ Misses 1272 1269 -3
+ Partials 246 245 -1
|
Aneurysm9
approved these changes
Mar 26, 2021
XSAM
approved these changes
Mar 28, 2021
MrAlias
approved these changes
Mar 31, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection errors on the OTLP/gRPC exporter gives users a very enigmatic error.
This PR wraps the connection error to the error returned to the user, giving them more details to diagnose problems.
Fixes #1735