Remove links on NewRoot spans#1726
Merged
Aneurysm9 merged 2 commits intoopen-telemetry:mainfrom Mar 25, 2021
Merged
Conversation
To ensure forwards compatibility, remove the unspecified links currently set on `NewRoot` spans. Resolves #461
Codecov Report
@@ Coverage Diff @@
## main #1726 +/- ##
=======================================
+ Coverage 77.8% 78.0% +0.1%
=======================================
Files 131 131
Lines 6984 6955 -29
=======================================
- Hits 5439 5426 -13
+ Misses 1295 1279 -16
Partials 250 250
|
XSAM
approved these changes
Mar 25, 2021
Aneurysm9
approved these changes
Mar 25, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure forwards compatibility, remove the unspecified links currently set on
NewRootspans. In resolving this theparent.GetSpanContextAndLinkswas simplified to return a local or remote parentSpanContextonly.Resolves #461