Removed setting error status while recording err as span event#1663
Merged
MrAlias merged 7 commits intoMar 8, 2021
Conversation
mrveera
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
…err as span event
mrveera
force-pushed
the
remove-setstatus-recrord-err
branch
from
5b3fffd to
3ec3208
Compare
Aneurysm9
reviewed
Mar 5, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
MrAlias
approved these changes
Mar 5, 2021
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
Minor doc/comment updates, but overall looks good 👍. Thanks 😄
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
XSAM
approved these changes
Mar 7, 2021
Member
XSAM
left a comment
XSAM
left a comment
There was a problem hiding this comment.
Looks good. I vote for this comment #1663 (comment)
mrveera
force-pushed
the
remove-setstatus-recrord-err
branch
from
171630a to
37eabd7
Compare
Aneurysm9
approved these changes
Mar 8, 2021
Merged
This was referenced Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1661