Adds semantic conventions for exceptions#1492
Merged
MrAlias merged 1 commit intoopen-telemetry:mainfrom Apr 1, 2021
mothership:task/jack/semconv-exceptions
Merged
Adds semantic conventions for exceptions#1492MrAlias merged 1 commit intoopen-telemetry:mainfrom mothership:task/jack/semconv-exceptions
MrAlias merged 1 commit intoopen-telemetry:mainfrom
mothership:task/jack/semconv-exceptions
Conversation
mothershipper
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1492 +/- ##
=====================================
Coverage 78.5% 78.5%
=====================================
Files 133 133
Lines 7083 7083
=====================================
Hits 5567 5567
Misses 1270 1270
Partials 246 246
|
XSAM
approved these changes
Jan 28, 2021
Aneurysm9
suggested changes
Feb 5, 2021
Member
Aneurysm9
left a comment
Aneurysm9
left a comment
There was a problem hiding this comment.
I would like to separate the change to semantic conventions from the decision whether to use RecordError, RecordException, or both.
mothershipper
changed the title
mothershipper
changed the title
MrAlias
requested changes
Feb 24, 2021
MrAlias
approved these changes
Mar 3, 2021
XSAM
approved these changes
Mar 13, 2021
Aneurysm9
approved these changes
Mar 18, 2021
MrAlias
approved these changes
Apr 1, 2021
Contributor
|
I'm not able to push to this branch. @mothershipper can you resolve the conflicts so we can merge this? |
Adds support for the opentelemetry exceptions semantic conventions. In short, this has RecordError produce an exception event with exception attributes instead of using the error event and error attributes. While golang does not have exceptions, the spec itself does not differentiate between errors and exceptions for recording purposes. RecordError was kept as the method name, both for backwards compatibility and to reduce confusion (the method signature takes in a golang error object). The spec appears to allow this, as it suggests the method is optional and signature may reflect whatever is most appropriate for the language implementing it. It may seem non-intuitive to log an exception event from a method called RecordError, but it's beneficial to have consistent behavior across all opentelemetry SDKs. Downstream projects like the opentelemetry-collector can build off of the published API and not special case behaviors from individual languages.
Contributor
Author
|
👍 rebased and pushed |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alters RecordError to support the opentelemetry semantic conventions for exceptions. In
short, this renames the
errorevent toexceptionand updates the attribute keys.*Fixes #1491