Skip to content

Update OTLP to v0.6.0 #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aneurysm9 merged 4 commits into from
Nov 20, 2020
Merged

Update OTLP to v0.6.0 #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d61cf7
Update opentelemetry-proto submodule to v0.6.0
MrAlias Nov 19, 2020
12ec766
Update generated code
MrAlias Nov 19, 2020
27e996b
Update the OTLP exporter with new proto
MrAlias Nov 20, 2020
d04c8ac
Update CHANGELOG
MrAlias Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- `EmptySpanContext` is removed.
- Move the `go.opentelemetry.io/otel/api/trace/tracetest` package into `go.opentelemetry.io/otel/oteltest`. (#1229)
- OTLP Exporter updates:
- supports OTLP v0.5.0 (#1230)
- supports OTLP v0.6.0 (#1230, #1354)
- supports configurable aggregation temporality (default: Cumulative, optional: Stateless). (#1296)
- The Sampler is now called on local child spans. (#1233)
- The `Kind` type from the `go.opentelemetry.io/otel/api/metric` package was renamed to `InstrumentKind` to more specifically describe what it is and avoid semantic ambiguity. (#1240)
Expand Down
2 changes: 1 addition & 1 deletion exporters/otlp/internal/opentelemetry-proto
Open in desktop
Submodule opentelemetry-proto updated 3 files
+8 −0 README.md
+81 −27 opentelemetry/proto/trace/v1/trace.proto
+6 −6 opentelemetry/proto/trace/v1/trace_config.proto
173 changes: 87 additions & 86 deletions exporters/otlp/internal/opentelemetry-proto-gen/collector/trace/v1/trace_config.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

364 changes: 221 additions & 143 deletions exporters/otlp/internal/opentelemetry-proto-gen/trace/v1/trace.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion exporters/otlp/internal/transform/span.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func status(status codes.Code, message string) *tracepb.Status {
var c tracepb.Status_StatusCode
switch status {
case codes.Error:
c = tracepb.Status_STATUS_CODE_UNKNOWN_ERROR
c = tracepb.Status_STATUS_CODE_ERROR
default:
c = tracepb.Status_STATUS_CODE_OK
}
Expand Down
2 changes: 1 addition & 1 deletion exporters/otlp/internal/transform/span_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func TestStatus(t *testing.T) {
{
codes.Error,
"test Error",
tracepb.Status_STATUS_CODE_UNKNOWN_ERROR,
tracepb.Status_STATUS_CODE_ERROR,
},
} {
expected := &tracepb.Status{Code: test.otlpStatus, Message: test.message}
Expand Down
2 changes: 1 addition & 1 deletion exporters/otlp/otlp_span_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ func TestExportSpans(t *testing.T) {
},
},
Status: &tracepb.Status{
Code: tracepb.Status_STATUS_CODE_UNKNOWN_ERROR,
Code: tracepb.Status_STATUS_CODE_ERROR,
Message: "Unauthenticated",
},
},
Expand Down