Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opencensus bridge example and readme #1348

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

dashpole
Copy link
Contributor

Issue: #93

This adds a README for the bridge and an example which uses it.

@dashpole
Copy link
Contributor Author

I believe this is a good candidate for the "skip changelog" label. It is only documentation and examples, and doesn't modify any APIs.

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 19, 2020
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to add the new module to the dependabot config.

@dashpole dashpole force-pushed the opencensus_bridge_example branch 3 times, most recently from 6395af7 to e8d345c Compare November 19, 2020 01:24
bridge/opencensus/README.md Outdated Show resolved Hide resolved
bridge/opencensus/README.md Outdated Show resolved Hide resolved
bridge/opencensus/README.md Show resolved Hide resolved
bridge/opencensus/README.md Outdated Show resolved Hide resolved
bridge/opencensus/examples/bridge/go.mod Outdated Show resolved Hide resolved
bridge/opencensus/examples/bridge/main.go Outdated Show resolved Hide resolved
bridge/opencensus/examples/bridge/main.go Outdated Show resolved Hide resolved
bridge/opencensus/examples/bridge/main.go Outdated Show resolved Hide resolved
bridge/opencensus/examples/bridge/main.go Outdated Show resolved Hide resolved
bridge/opencensus/examples/bridge/main.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 4619c06 into open-telemetry:master Nov 19, 2020
@dashpole dashpole deleted the opencensus_bridge_example branch November 19, 2020 21:00
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
* add opencensus bridge example

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <[email protected]>

Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants