-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opencensus bridge example and readme #1348
Merged
MrAlias
merged 2 commits into
open-telemetry:master
from
dashpole:opencensus_bridge_example
Nov 19, 2020
Merged
Add opencensus bridge example and readme #1348
MrAlias
merged 2 commits into
open-telemetry:master
from
dashpole:opencensus_bridge_example
Nov 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
November 19, 2020 00:44
dashpole
force-pushed
the
opencensus_bridge_example
branch
from
November 19, 2020 00:59
ebd0674
to
303ffdf
Compare
I believe this is a good candidate for the "skip changelog" label. It is only documentation and examples, and doesn't modify any APIs. |
Aneurysm9
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to add the new module to the dependabot config.
dashpole
force-pushed
the
opencensus_bridge_example
branch
3 times, most recently
from
November 19, 2020 01:24
6395af7
to
e8d345c
Compare
dashpole
force-pushed
the
opencensus_bridge_example
branch
from
November 19, 2020 03:32
e8d345c
to
6d781c0
Compare
MrAlias
reviewed
Nov 19, 2020
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Nov 19, 2020
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* add opencensus bridge example * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #93
This adds a README for the bridge and an example which uses it.