Add opencensus binary propagation to bridge #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
dashpole
force-pushed
the
opencensus_binary
branch
from
5b3bf69
to
041ee1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
======================================
Coverage 77.4% 77.5%
======================================
Files 123 125 +2
Lines 6067 6090 +23
======================================
+ Hits 4697 4720 +23
- Misses 1116 1119 +3
+ Partials 254 251 -3
|
dashpole
force-pushed
the
opencensus_binary
branch
from
041ee1a
to
b120978
Compare
Aneurysm9
approved these changes
Nov 16, 2020
MrAlias
approved these changes
Nov 16, 2020
dashpole
force-pushed
the
opencensus_binary
branch
from
ee4e655
to
c143fe2
Compare
|
I don't think the failure is related |
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
dashpole
force-pushed
the
opencensus_binary
branch
from
c143fe2
to
a441b95
Compare
Agreed. |
dashpole
added a commit
to dashpole/opentelemetry-go
that referenced
this pull request
Nov 19, 2020
dashpole
added a commit
to dashpole/opentelemetry-go
that referenced
this pull request
Nov 20, 2020
MrAlias
added a commit
that referenced
this pull request
Nov 20, 2020
Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* add opencensus binary propagation bridge * Update bridge/opencensus/binary/binary.go Co-authored-by: Tyler Yahn <[email protected]> * Update bridge/opencensus/doc.go Co-authored-by: Tyler Yahn <[email protected]> * address comments Co-authored-by: Tyler Yahn <[email protected]>
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
open-telemetry#1353) Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #93
The OpenCensus ocgrpc plugin has hardcoded the use of its binary propagation format, under the "grpc-trace-bin" key.
In order to migrate from ocgrpc to otelgrpc, users need to be able to use the opencensus binary propagation format in opentelemetry. This PR implements the TextMapCarrier interface using the opencensus binary propagation libraries.
This PR also extracts common functions into a utils package, fixes the import comments on packages, and makes the go version used (1.14) consistent with the rest of the repository.