Pass options to configured TracerProvider#1329
Merged
MrAlias merged 2 commits intoopen-telemetry:masterfrom Nov 17, 2020
Merged
Pass options to configured TracerProvider#1329MrAlias merged 2 commits intoopen-telemetry:masterfrom
MrAlias merged 2 commits intoopen-telemetry:masterfrom
Conversation
|
9599142 to
ebbc27f
Compare
ebbc27f to
cc3659f
Compare
Aneurysm9
approved these changes
Nov 16, 2020
Contributor
|
@cbandy sorry, it looks like upstream package reshuffling has caused conflicts here. You should be able to use |
Contributor
Author
|
No problem. I can rebase tonight. |
cc3659f to
18f2d67
Compare
Contributor
Author
|
Rebased. |
XSAM
approved these changes
Nov 17, 2020
dashpole
approved these changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
======================================
Coverage 77.5% 77.5%
======================================
Files 125 125
Lines 6090 6090
======================================
Hits 4720 4720
Misses 1119 1119
Partials 251 251
|
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global TracerProvider missed some arguments to its configured TracerProvider.
I wasn't sure how to describe the placeholder or the test. Suggestions welcome.
I looked for a similar bug in the global MeterProvider and found none, but the implementation was harder for me to follow there. I am certain, however, the correct behavior isn't covered by current tests. I was able to apply this diff and everything still passed: