Skip to content

feat(semconv): Add DeploymentEnvironmentKey to semconv package#1323

Merged
MrAlias merged 2 commits intoopen-telemetry:masterfrom
seanschade:semconv-deployment-environment
Nov 16, 2020
Merged

feat(semconv): Add DeploymentEnvironmentKey to semconv package#1323
MrAlias merged 2 commits intoopen-telemetry:masterfrom
seanschade:semconv-deployment-environment

Conversation

@seanschade
Copy link
Copy Markdown
Contributor

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID

1 similar comment
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID

@seanschade seanschade force-pushed the semconv-deployment-environment branch from 11b2f37 to de66525 Compare November 12, 2020 00:50
@MrAlias MrAlias added the blocked:CLA Waiting on CLA to be signed before progress can be made label Nov 12, 2020
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Nov 12, 2020

@seanschade I think the CLA bot is complaining because you do not have an email attached to the commits pushed. Can you check this and add on if not?

@seanschade
Copy link
Copy Markdown
Contributor Author

@seanschade I think the CLA bot is complaining because you do not have an email attached to the commits pushed. Can you check this and add on if not?

I initially had the wrong email associated which caused those issues, and then pushed a commit to fix it. It looks. like the EasyCLA check has passed.

@seanschade seanschade requested a review from MrAlias November 12, 2020 23:53
@seanschade
Copy link
Copy Markdown
Contributor Author

@MrAlias the CLA should be good to go now. Thanks.

@MrAlias MrAlias removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Nov 13, 2020
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Nov 13, 2020

@seanschade can you squash the commits into a single commit that is signed by the appropriate email and force push that to the branch to remove 078a5d0 from the commit list?

@MrAlias MrAlias added this to the RC1 milestone Nov 13, 2020
@seanschade
Copy link
Copy Markdown
Contributor Author

seanschade commented Nov 16, 2020

@seanschade can you squash the commits into a single commit that is signed by the appropriate email and force push that to the branch to remove 078a5d0 from the commit list?

@MrAlias this is done. Let me know if there is anything else I can do.

I will squash commits in the future as well.

feat(semconv): Add DeploymentEnvironmentKey to semconv package
@seanschade seanschade force-pushed the semconv-deployment-environment branch from afcab94 to 485f6e3 Compare November 16, 2020 18:09
@MrAlias MrAlias merged commit 73a0539 into open-telemetry:master Nov 16, 2020
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Nov 16, 2020

Thanks for the contribution 😄

@seanschade seanschade deleted the semconv-deployment-environment branch November 16, 2020 18:29
@MrAlias MrAlias mentioned this pull request Nov 20, 2020
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
feat(semconv): Add DeploymentEnvironmentKey to semconv package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants