feat(semconv): Add DeploymentEnvironmentKey to semconv package#1323
Conversation
|
|
1 similar comment
|
11b2f37 to
de66525
Compare
|
@seanschade I think the CLA bot is complaining because you do not have an email attached to the commits pushed. Can you check this and add on if not? |
I initially had the wrong email associated which caused those issues, and then pushed a commit to fix it. It looks. like the EasyCLA check has passed. |
|
@MrAlias the CLA should be good to go now. Thanks. |
|
@seanschade can you squash the commits into a single commit that is signed by the appropriate email and force push that to the branch to remove 078a5d0 from the commit list? |
@MrAlias this is done. Let me know if there is anything else I can do. I will squash commits in the future as well. |
feat(semconv): Add DeploymentEnvironmentKey to semconv package
afcab94 to
485f6e3
Compare
|
Thanks for the contribution 😄 |
feat(semconv): Add DeploymentEnvironmentKey to semconv package
I noticed the
deployment.environmentkey was missing while instrumenting my applications.https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resource/semantic_conventions/deployment_environment.md