Skip to content

Move metric code to a separate package#1321

Merged
MrAlias merged 2 commits intoopen-telemetry:masterfrom
krnowak:new-api-3
Nov 12, 2020
Merged

Move metric code to a separate package#1321
MrAlias merged 2 commits intoopen-telemetry:masterfrom
krnowak:new-api-3

Conversation

@krnowak
Copy link
Copy Markdown
Member

@krnowak krnowak commented Nov 11, 2020

Part of #1303

@krnowak
Copy link
Copy Markdown
Member Author

krnowak commented Nov 11, 2020

I'm not really sure if the changelog entry is correct. Was the metrictest package merged into metric package or it rather went into oteltest package?

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 11, 2020

Codecov Report

Merging #1321 (70f9ed6) into master (386331a) will not change coverage.
The diff coverage is 92.3%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1321   +/-   ##
======================================
  Coverage    77.3%   77.3%           
======================================
  Files         122     122           
  Lines        5978    5978           
======================================
  Hits         4622    4622           
  Misses       1107    1107           
  Partials      249     249           
Impacted Files Coverage Δ
exporters/metric/prometheus/prometheus.go 57.6% <ø> (ø)
exporters/otlp/otlp.go 77.0% <ø> (ø)
exporters/stdout/metric.go 76.5% <ø> (ø)
global/internal/state.go 100.0% <ø> (ø)
global/metric.go 100.0% <ø> (ø)
metric/config.go 80.0% <ø> (ø)
metric/instrumentkind_string.go 10.0% <ø> (ø)
metric/metric.go 52.5% <ø> (ø)
metric/metric_instrument.go 88.1% <ø> (ø)
metric/metric_noop.go 0.0% <ø> (ø)
... and 22 more

@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Nov 11, 2020

I'm not really sure if the changelog entry is correct. Was the metrictest package merged into metric package or it rather went into oteltest package?

It was merged into the oteltest package. I didn't include that package in this encapsulation, but am not sure the best course of action there. It felt appropriate for a separate issue.

@krnowak
Copy link
Copy Markdown
Member Author

krnowak commented Nov 11, 2020

I'm not really sure if the changelog entry is correct. Was the metrictest package merged into metric package or it rather went into oteltest package?

It was merged into the oteltest package.

Alright, I'll amend the changelog to mention this.

I didn't include that package in this encapsulation, but am not sure the best course of action there. It felt appropriate for a separate issue.

oteltest seems to be a part of the encapsulation proposal, and it basically stays as is. Not sure if there is any action required.

@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Nov 11, 2020

oteltest seems to be a part of the encapsulation proposal, and it basically stays as is. Not sure if there is any action required.

I'm going to add this to tomorrows SIG meeting agenda. I'm interested to hear if others have suggestions.

@MrAlias MrAlias merged commit 75d4911 into open-telemetry:master Nov 12, 2020
@krnowak krnowak deleted the new-api-3 branch November 12, 2020 16:10
@MrAlias MrAlias mentioned this pull request Nov 20, 2020
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
* Move metrics code to metric package

* Update changelog
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants