Skip to content

Update span collection limits to 1000 #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrAlias merged 4 commits into from
Nov 10, 2020
Merged

Update span collection limits to 1000 #1318

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0447d1b
set collection limit to 1000
Nov 9, 2020
a4aab73
update changelog
Nov 9, 2020
fd338ba
Merge branch 'master' into update-limits
Nov 9, 2020
ce75812
Merge branch 'master' into update-limits
MrAlias Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The `resource.New()` method changes signature to support builtin attributes and functional options, including `telemetry.sdk.*` and
`host.name` semantic conventions; the former method is renamed `resource.NewWithAttributes`. (#1235)
- Correct the `Span.End` method documentation in the `otel` API to state updates are not allowed on a span after it has ended. (#1310)
- Updated span collection limits for attribute, event and link counts to 1000 (#1318)

### Removed

Expand Down
6 changes: 3 additions & 3 deletions sdk/trace/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ type Config struct {

const (
// DefaultMaxEventsPerSpan is default max number of message events per span
DefaultMaxEventsPerSpan = 128
DefaultMaxEventsPerSpan = 1000

// DefaultMaxAttributesPerSpan is default max number of attributes per span
DefaultMaxAttributesPerSpan = 32
DefaultMaxAttributesPerSpan = 1000

// DefaultMaxLinksPerSpan is default max number of links per span
DefaultMaxLinksPerSpan = 32
DefaultMaxLinksPerSpan = 1000
)