Skip to content

Move tracing code to trace package#1307

Merged
Aneurysm9 merged 2 commits intoopen-telemetry:masterfrom
krnowak:new-api
Nov 6, 2020
Merged

Move tracing code to trace package#1307
Aneurysm9 merged 2 commits intoopen-telemetry:masterfrom
krnowak:new-api

Conversation

@krnowak
Copy link
Copy Markdown
Member

@krnowak krnowak commented Nov 4, 2020

This PR is a first part of N to resolve issue #1303.

Other than rather mechanical work of moving files to a subpackage and changing the used package name for the moved types in other packages from otel to trace it also does the following:

  • Moved tracing parts of config.go to trace.
  • Duplicated InstrumentationOption and WithInstrumentationVersion in trace (see trace/config.go).
  • Added nolint:golint for trace.TraceID and trace.TraceIDFromHex (in `trace/trace.go).

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Nov 4, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2020

Codecov Report

Merging #1307 into master will increase coverage by 0.0%.
The diff coverage is 81.5%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1307   +/-   ##
======================================
  Coverage    77.2%   77.2%           
======================================
  Files         121     122    +1     
  Lines        5954    5955    +1     
======================================
+ Hits         4600    4601    +1     
  Misses       1111    1111           
  Partials      243     243           
Impacted Files Coverage Δ
bridge/opentracing/util.go 100.0% <ø> (ø)
config.go 80.0% <ø> (-13.1%) ⬇️
exporters/stdout/exporter.go 25.9% <ø> (ø)
global/internal/state.go 100.0% <ø> (ø)
global/internal/trace.go 88.8% <ø> (ø)
global/trace.go 66.6% <ø> (ø)
internal/trace/parent/parent.go 0.0% <0.0%> (ø)
sdk/trace/sampling.go 100.0% <ø> (ø)
trace/trace.go 80.0% <ø> (ø)
trace/trace_noop.go 57.1% <ø> (ø)
... and 19 more

Copy link
Copy Markdown
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krnowak can we update this line of the CHANGELOG to correctly describe where things were moved and include this PR in addition?

@krnowak
Copy link
Copy Markdown
Member Author

krnowak commented Nov 4, 2020

Changelog updated, docs are still a TODO, but I suppose I could do them later, when the all the code is in its final place.

@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing pkg:API Related to an API package priority:p1 labels Nov 5, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 5, 2020
@krnowak krnowak mentioned this pull request Nov 5, 2020
@krnowak
Copy link
Copy Markdown
Member Author

krnowak commented Nov 5, 2020

Rebased.

@Aneurysm9 Aneurysm9 merged commit 3268501 into open-telemetry:master Nov 6, 2020
@krnowak krnowak deleted the new-api branch November 10, 2020 17:41
johananl added a commit to kinvolk/opentelemetry-go that referenced this pull request Nov 12, 2020
@MrAlias MrAlias mentioned this pull request Nov 20, 2020
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
* Move tracing code to trace package

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:trace Part of OpenTelemetry tracing pkg:API Related to an API package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants