Move tracing code to trace package#1307
Merged
Aneurysm9 merged 2 commits intoopen-telemetry:masterfrom Nov 6, 2020
krnowak:new-api
Merged
Move tracing code to trace package#1307Aneurysm9 merged 2 commits intoopen-telemetry:masterfrom krnowak:new-api
Aneurysm9 merged 2 commits intoopen-telemetry:masterfrom
krnowak:new-api
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
======================================
Coverage 77.2% 77.2%
======================================
Files 121 122 +1
Lines 5954 5955 +1
======================================
+ Hits 4600 4601 +1
Misses 1111 1111
Partials 243 243
|
MrAlias
approved these changes
Nov 4, 2020
Member
Author
|
Changelog updated, docs are still a TODO, but I suppose I could do them later, when the all the code is in its final place. |
Closed
Member
Author
|
Rebased. |
Aneurysm9
approved these changes
Nov 6, 2020
johananl
added a commit
to kinvolk/opentelemetry-go
that referenced
this pull request
Nov 12, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Move tracing code to trace package * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is a first part of N to resolve issue #1303.
Other than rather mechanical work of moving files to a subpackage and changing the used package name for the moved types in other packages from
oteltotraceit also does the following:config.gototrace.InstrumentationOptionandWithInstrumentationVersionintrace(seetrace/config.go).trace.TraceIDandtrace.TraceIDFromHex(in `trace/trace.go).