Remove MockSpan and MockTracer#1306
Merged
MrAlias merged 3 commits intoopen-telemetry:masterfrom Nov 5, 2020
Merged
Conversation
matej-g
requested review from
Aneurysm9,
MrAlias,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
========================================
+ Coverage 77.1% 77.2% +0.1%
========================================
Files 123 121 -2
Lines 5985 5954 -31
========================================
- Hits 4616 4600 -16
+ Misses 1121 1111 -10
+ Partials 248 243 -5
|
MrAlias
reviewed
Nov 4, 2020
MrAlias
approved these changes
Nov 5, 2020
…ckspan-mocktracer
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Remove MockSpan and MockTracer * Update CHANGELOG Co-authored-by: Tyler Yahn <codingalias@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently,
MockSpanandMockTracerstructs live in theoteltestpackage besidesSpanandTracerstructs. However, both pairs represent structs which are functionally similar. This is redundant. It is suggested to merge each pair and retain onlyoteltest.Spanandoteltest.Tracer.Resloves #1129