Add global propagator testing and other fixes#1260
Merged
MrAlias merged 4 commits intoopen-telemetry:masterfrom Oct 17, 2020
Merged
Add global propagator testing and other fixes#1260MrAlias merged 4 commits intoopen-telemetry:masterfrom
MrAlias merged 4 commits intoopen-telemetry:masterfrom
Conversation
Use the testing framework from open-telemetry#1259 to test the added global implementation of the TextMapPropagator. Add tests for the internal state of the global package. Ensure the behavior of setting the global for an already set value panics. Fix oteltest `SetN` method check on the TextMapCarrier.
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
========================================
+ Coverage 76.4% 76.9% +0.4%
========================================
Files 132 132
Lines 5928 5927 -1
========================================
+ Hits 4533 4561 +28
+ Misses 1146 1116 -30
- Partials 249 250 +1
|
Aneurysm9
approved these changes
Oct 15, 2020
jmacd
approved these changes
Oct 16, 2020
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Add global propagator testing and other fixes Use the testing framework from open-telemetry#1259 to test the added global implementation of the TextMapPropagator. Add tests for the internal state of the global package. Ensure the behavior of setting the global for an already set value panics. Fix oteltest `SetN` method check on the TextMapCarrier. * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the testing framework from #1259 to test the added global implementation of the TextMapPropagator.
Add tests for the internal state of the global package (#1258). Ensure the behavior of setting the global for an already set value panics.
Fix oteltest
SetNmethod check on the TextMapCarrier.