Fix lint issues in otel package#1243
Merged
MrAlias merged 5 commits intoopen-telemetry:masterfrom Oct 12, 2020
Merged
Conversation
Add documentation for the shadowed `Meter` for the time being. Do not export `ErrInvalidHexID`, `ErrInvalidTraceIDLength`, `ErrInvalidSpanIDLength`, `ErrInvalidSpanIDLength`, or `ErrNilSpanID`. These are not used externally and we should reduce the API prior to a GA release to allow flexibility going forward. Add and update comments for all SpanKind conforming to golint spec.
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Aneurysm9
approved these changes
Oct 11, 2020
XSAM
approved these changes
Oct 12, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Fix lint issues in otel package Add documentation for the shadowed `Meter` for the time being. Do not export `ErrInvalidHexID`, `ErrInvalidTraceIDLength`, `ErrInvalidSpanIDLength`, `ErrInvalidSpanIDLength`, or `ErrNilSpanID`. These are not used externally and we should reduce the API prior to a GA release to allow flexibility going forward. Add and update comments for all SpanKind conforming to golint spec. * Update CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the shadowed
Meterfor the time being.Do not export
ErrInvalidHexID,ErrInvalidTraceIDLength,ErrInvalidSpanIDLength,ErrInvalidSpanIDLength, orErrNilSpanID. These are not used externally and we should reduce the API prior to a GA release to allow flexibility going forward.Add and update comments for all
SpanKindconforming to golint spec.