Skip to content

Move api/apitest into the otel/oteltest package#1241

Merged
MrAlias merged 7 commits intoopen-telemetry:masterfrom
MrAlias:mv-apitest
Oct 12, 2020
Merged

Move api/apitest into the otel/oteltest package#1241
MrAlias merged 7 commits intoopen-telemetry:masterfrom
MrAlias:mv-apitest

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Oct 11, 2020 •
edited
Loading

Move the existing test harness into the oteltest package and update exported type and functions documentation.

Part of #964

@MrAlias MrAlias added pkg:testing Related to testing or a testing package area:trace Part of OpenTelemetry tracing release:required-for-ga Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 11, 2020
@MrAlias MrAlias self-assigned this Oct 11, 2020
@MrAlias MrAlias removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 11, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 11, 2020 •
edited
Loading

Codecov Report

Merging #1241 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1241   +/-   ##
======================================
  Coverage    76.7%   76.7%           
======================================
  Files         130     130           
  Lines        5828    5828           
======================================
+ Hits         4471    4475    +4     
+ Misses       1110    1105    -5     
- Partials      247     248    +1
Impacted Files Coverage Δ
oteltest/harness.go 100.0% <ø> (ø)
label/set.go 57.1% <0.0%> (ø)
label/value.go 90.2% <0.0%> (ø)
exporters/otlp/otlp.go 76.9% <0.0%> (ø)
exporters/otlp/options.go 50.0% <0.0%> (ø)
api/metric/metrictest/meter.go 100.0% <0.0%> (ø)
internal/metric/async.go
api/metric/metrictest/async.go 77.7% <0.0%> (ø)
sdk/trace/batch_span_processor.go 78.4% <0.0%> (+4.3%) ⬆️

@MrAlias MrAlias added this to the RC1 milestone Oct 11, 2020
@MrAlias MrAlias marked this pull request as ready for review October 11, 2020 18:52
@MrAlias MrAlias merged commit 65044a1 into open-telemetry:master Oct 12, 2020
@MrAlias MrAlias deleted the mv-apitest branch October 12, 2020 15:47
@MrAlias MrAlias mentioned this pull request Nov 20, 2020
Merged
AzfaarQureshi pushed a commit to open-o11y/opentelemetry-go that referenced this pull request Dec 3, 2020
@MrAlias
Move api/apitest into the otel/oteltest package (open-telemetry#1241
3179972 
)

* Move the apitest package into oteltest

* Add documentation to exported func and type

* Add changes to CHANGELOG

* Update move in other modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XSAM XSAM XSAM approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

+1 more reviewer

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MrAlias MrAlias

Labels

area:trace Part of OpenTelemetry tracing pkg:testing Related to testing or a testing package

Projects

None yet

Milestone

RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@MrAlias @Aneurysm9 @XSAM