Rename Kind from the api/metric package#1240
Merged
MrAlias merged 11 commits intoopen-telemetry:masterfrom Oct 13, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
========================================
- Coverage 76.8% 76.7% -0.1%
========================================
Files 130 130
Lines 5828 5828
========================================
- Hits 4477 4475 -2
- Misses 1104 1105 +1
- Partials 247 248 +1
|
MrAlias
added
area:metrics
MrAlias
requested review from
Aneurysm9,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Aneurysm9
approved these changes
Oct 11, 2020
XSAM
approved these changes
Oct 13, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Update metric Kind to InstrumentKind * Update all the other modules with Kind rename * Update metric Descriptor with instrument Kind rename * Update other modules with Descriptor method rename * Update OTLP exporter test field name * Rename kind filenames * Add changes to CHANGELOG * Fix documentation for Grouping and PrecomputedSum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #964 the
Kindtype from theapi/metricpackage needs to renamed to be more specific of what kind of thing it represents. In following with the common practice of not using the term metric as a noun, this kind is renamed toInstrumentKindto describe the metric instruments it describes.Additionally, the
Descriptor.MetricKindmethod is updated to match.