Call sampler on local child spans.#1233
Merged
Aneurysm9 merged 4 commits intoopen-telemetry:masterfrom Oct 9, 2020
honeycombio:paul.sampler-with-child-spans
Merged
Call sampler on local child spans.#1233Aneurysm9 merged 4 commits intoopen-telemetry:masterfrom honeycombio:paul.sampler-with-child-spans
Aneurysm9 merged 4 commits intoopen-telemetry:masterfrom
honeycombio:paul.sampler-with-child-spans
Conversation
paulosman
requested review from
Aneurysm9,
MrAlias,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
======================================
Coverage 76.7% 76.7%
======================================
Files 130 130
Lines 5832 5828 -4
======================================
Hits 4475 4475
+ Misses 1110 1105 -5
- Partials 247 248 +1
|
Aneurysm9
reviewed
Oct 8, 2020
MrAlias
approved these changes
Oct 8, 2020
Aneurysm9
approved these changes
Oct 8, 2020
MrAlias
added
area:trace
XSAM
approved these changes
Oct 9, 2020
Contributor
|
@paulosman it looks like maintainer edits are turned off for this PR so I can't merge master into this. If you can do this sync this PR looks ready to merge. |
MrAlias
reviewed
Oct 9, 2020
lizthegrey
suggested changes
Oct 9, 2020
Member
lizthegrey
left a comment
lizthegrey
left a comment
There was a problem hiding this comment.
please write tests for this.
Member
Author
Added a test to catch local child spans. Build is fixed, but circle seems stuck - pushed a changed and it won't rebuild. |
lizthegrey
approved these changes
Oct 9, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Call sampler on local child spans. * Update CHANGELOG.md * Adding a test for calling the sampler on local child spans * Add clarifying comment to test
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1228
Previously, the sampler would only be called for the first span in a process. This makes sense for trace level sampling but doesn't allow the sampler to specify attributes to be set on each span, which is important for some implementations. This change removes the guard that limits sampling decisions to local root spans.