Change name of ProbabilitySampler to TraceIdRatioBased #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify behavior to ignore parent span * Add test for inclusivity property on TraceIdRatioBased sampler * Modify tests in `trace_test.go` to reflect change in parent span behavior
evantorrie
requested review from
Aneurysm9,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
========================================
- Coverage 77.1% 77.1% -0.1%
========================================
Files 133 133
Lines 7109 7106 -3
========================================
- Hits 5488 5483 -5
Misses 1371 1371
- Partials 250 252 +2
|
|
Original issue #1083 says to change the name to I guess it is more congruent with |
MrAlias
approved these changes
Sep 2, 2020
Co-authored-by: Tyler Yahn <[email protected]>
evantorrie
added a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
…y#1115) * Change name of ProbabilitySampler to TraceIdRatioBased * Modify behavior to ignore parent span * Add test for inclusivity property on TraceIdRatioBased sampler * Modify tests in `trace_test.go` to reflect change in parent span behavior * Add to CHANGELOG * Satisfy golint * Update CHANGELOG.md Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
KasonBraley
added a commit
to KasonBraley/opentelemetry-go-contrib
that referenced
this pull request
Feb 16, 2023
Update the examples to use the current API for configuring production sampling. These names were changed a couple of years ago. open-telemetry/opentelemetry-go#1115 open-telemetry/opentelemetry-go#1153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1083
trace_test.goto reflect change in parent span behavior