Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WithSpan method from Tracer interface #1043

Merged
merged 8 commits into from
Aug 8, 2020
Merged

Remove WithSpan method from Tracer interface #1043

merged 8 commits into from
Aug 8, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 6, 2020

  • Remove WithSpan from Tracer interface in trace API.
  • Update all usage and documentation about the WithSpan method.
  • Add panic recovery to the End method in the SDK implementation.

Resolves #1013

@MrAlias MrAlias self-assigned this Aug 6, 2020
@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing pkg:API Related to an API package labels Aug 6, 2020
Aneurysm9
Aneurysm9 approved these changes Aug 7, 2020
View reviewed changes
example/namedtracer/foo/foo.go Show resolved Hide resolved
@MrAlias MrAlias merged commit 2dfa5e4 into open-telemetry:master Aug 8, 2020
@MrAlias MrAlias deleted the rm-withspan branch August 8, 2020 19:10
@Aneurysm9 Aneurysm9 mentioned this pull request Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@jmacd jmacd jmacd approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees

@MrAlias MrAlias

Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove WithSpan
3 participants
@MrAlias @Aneurysm9 @jmacd